Skip to content

android: patch RN settings.gradle.kts /tmp projectDir for Windows - #387

Merged
kraenhansen merged 2 commits into
kh/adopt-static-h-node-apifrom
claude/windows-gradle9-projectdir
Aug 9, 2026
Merged

android: patch RN settings.gradle.kts /tmp projectDir for Windows#387
kraenhansen merged 2 commits into
kh/adopt-static-h-node-apifrom
claude/windows-gradle9-projectdir

Conversation

@kraenhansen

@kraenhansen kraenhansen commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

Targets the kh/adopt-static-h-node-api branch (PR #372). Follow-up to #386, which greened ubuntu + macOS but left windows-latest red on a different cause.

Root cause

After #386 fixed the Project.exec() removal, the Windows Gradle build got further and both gradle.test.ts cases failed at configuration time:

Configuring project ':packages:react-native' without an existing directory is not allowed.
The configured projectDirectory '...\react-native@0.87...\node_modules\react-native\tmp' does not exist

This is upstream React Native, not our code. RN's own settings.gradle.kts (used for build-from-source composite builds, which this project requires) declares the intermediate container projects with a throwaway dir:

// Since Gradle 9.0, all the projects in the path must have an existing folder.
project(":packages").projectDir = file("/tmp")
project(":packages:react-native").projectDir = file("/tmp")

/tmp exists on the posix CI hosts, so ubuntu/macOS pass. On Windows /tmp is not absolute, so Gradle resolves it to a non-existent <react-native>\tmp, and Gradle 9 hard-errors on a missing projectDirectory — failing before any task runs.

Fix

A pnpm patch on our pinned RN nightly, replacing file("/tmp") with file(System.getProperty("java.io.tmpdir", "/tmp")) — the JVM temp dir, which is /tmp on posix and %TEMP% on Windows and always exists.

Files:

  • patches/react-native@0.87.0-nightly-20260529-88857d22f.patch
  • pnpm-workspace.yaml (patchedDependencies entry)
  • pnpm-lock.yaml

Scope and tradeoffs — read before merging

This patch is deliberately workspace-only. It is not distributed to consumers of react-native-node-api.

patchedDependencies in pnpm-workspace.yaml applies to installs in this repo only. It is not part of the published packages/host tarball, and it does not apply to a user's app even if they also use pnpm. So merging this fixes our CI, and nothing else.

What that means for users, concretely:

  • react-native-node-api requires building React Native from source on Android (we need Hermes patched with Node-API — see docs/ANDROID.md). That is exactly the code path this RN bug breaks.
  • Therefore, on Windows hosts, a user on an RN version that still hardcodes /tmp cannot build their Android app at all — it fails at Gradle configuration time, before any of our code runs.
  • macOS and Linux hosts are unaffected (/tmp exists there), so this is a Windows-only user-facing gap.
  • There is no workaround we can ship. The failure is in RN's settings.gradle.kts, evaluated during Gradle's settings phase of the composite build. Our Gradle plugin and our npm package are both loaded too late to intervene. The only real fixes are the upstream change, or the user applying an equivalent patch in their own app.

Why not distribute it anyway: we'd have to ask every consumer to add a patch for a specific RN version string, which breaks the moment they bump RN, and it would only ever have helped the subset of users who (a) are on Windows and (b) pin the same RN nightly we do. The upstream fix is already merged; carrying a distributable patch would be maintenance for a window that's closing on its own.

Removal gate

The upstream fix is merged: facebook/react-native#57706, landed on main as 908872a6 on 2026-07-28.

It landed after the 0.87 branch cut, so 0.87-stable does not carry it — 0.87.0 final (currently at rc.4) will still be broken on Windows unless someone cherry-picks it. Revert this patch once we pin a react-native that actually contains 908872a6:

  • a nightly built from main on/after 2026-07-29 (our current pin is 0.87.0-nightly-20260529, which predates it), or
  • the first stable line branched after it (0.88+), or
  • a 0.87.x that cherry-picks it.

Bumping the pinned nightly past 2026-07-29 would drop the patch outright — but that's a much larger change to land on top of the static_h work in #372, so it's intentionally left out of this PR.

The same condition is recorded as a comment inside the patch itself, so whoever next touches it doesn't have to find this PR.

Test plan

  • CI on this branch: Unit tests (windows-latest) green; ubuntu/macOS green.

The native Android build isn't runnable on the worker this was authored on, so cross-platform behaviour is verified by CI rather than locally.


Generated by Claude Code

The Windows unit-test lane failed configuring the React Native build-from-
source composite build:

    Configuring project ':packages:react-native' without an existing directory
    is not allowed. The configured projectDirectory '...\react-native\tmp'
    does not exist

React Native's own settings.gradle.kts declares the intermediate container
projects :packages and :packages:react-native with projectDir = file("/tmp"),
purely to satisfy Gradle 9's rule that every project in a path have an existing
folder. "/tmp" exists on the posix CI hosts but on Windows it is not an
absolute path, so Gradle resolves it to a non-existent <react-native>\tmp and
the build fails before any task runs. This is why only windows-latest was red
while ubuntu and macOS passed.

Add a pnpm patch replacing file("/tmp") with
file(System.getProperty("java.io.tmpdir", "/tmp")): the JVM temp dir is "/tmp"
on posix and %TEMP% on Windows, both of which always exist. Remove the patch
once React Native stops hardcoding "/tmp" upstream.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TVfanKvtyfSsoMgZv3DJtY
meta-codesync Bot pushed a commit to react/react-native that referenced this pull request Jul 28, 2026
…ed /tmp (#57706)

Summary:
`packages/react-native/settings.gradle.kts` declares the intermediate container projects `:packages` and `:packages:react-native` with `projectDir = file("/tmp")`, to satisfy Gradle 9's requirement that every project in a path have an existing folder. `/tmp` exists on posix hosts, but on Windows it is not an absolute path, so Gradle resolves it to a non-existent `<rootDir>\tmp` and build-from-source fails at configuration time:

    Configuring project ':packages:react-native' without an existing directory
    is not allowed.

Use `System.getProperty("java.io.tmpdir", "/tmp")` instead — the JVM temp dir, which is `/tmp` on posix and `%TEMP%` on Windows, and always exists.

## Changelog

[ANDROID] [FIXED] - Use the JVM temp dir instead of a hardcoded `/tmp` for the build-from-source container project dirs, fixing Gradle configuration on Windows

Pull Request resolved: #57706

Test Plan:
- posix: the resolved dir is unchanged (`/tmp`); build-from-source configures as before.
- Windows: resolves to an existing temp dir, so `includeBuild(../node_modules/react-native)`
  configures successfully instead of erroring.
- Downstream evidence: this exact change greened the `windows-latest` Gradle lane in
  callstackincubator/react-native-node-api#387.

Reviewed By: christophpurrer

Differential Revision: D113816859

Pulled By: Abbondanzo

fbshipit-source-id: 9846dadab9012369dcab26aa05ea3297633acf9f
The upstream fix landed on react-native main as 908872a6 (2026-07-28,
react/react-native#57706), after the 0.87 branch cut — so 0.87-stable
does not carry it. Record that in the patch comment so the removal gate is
a concrete react-native version rather than "once upstream fixes it".

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@kraenhansen
kraenhansen merged commit 8fc7527 into kh/adopt-static-h-node-api Aug 9, 2026
9 checks passed
@kraenhansen
kraenhansen deleted the claude/windows-gradle9-projectdir branch August 9, 2026 18:57
kraenhansen added a commit that referenced this pull request Aug 9, 2026
* android: patch RN settings.gradle.kts /tmp projectDir for Windows

The Windows unit-test lane failed configuring the React Native build-from-
source composite build:

    Configuring project ':packages:react-native' without an existing directory
    is not allowed. The configured projectDirectory '...\react-native\tmp'
    does not exist

React Native's own settings.gradle.kts declares the intermediate container
projects :packages and :packages:react-native with projectDir = file("/tmp"),
purely to satisfy Gradle 9's rule that every project in a path have an existing
folder. "/tmp" exists on the posix CI hosts but on Windows it is not an
absolute path, so Gradle resolves it to a non-existent <react-native>\tmp and
the build fails before any task runs. This is why only windows-latest was red
while ubuntu and macOS passed.

Add a pnpm patch replacing file("/tmp") with
file(System.getProperty("java.io.tmpdir", "/tmp")): the JVM temp dir is "/tmp"
on posix and %TEMP% on Windows, both of which always exist. Remove the patch
once React Native stops hardcoding "/tmp" upstream.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TVfanKvtyfSsoMgZv3DJtY

* android: point RN /tmp patch at the merged upstream fix

The upstream fix landed on react-native main as 908872a6 (2026-07-28,
react/react-native#57706), after the 0.87 branch cut — so 0.87-stable
does not carry it. Record that in the patch comment so the removal gate is
a concrete react-native version rather than "once upstream fixes it".

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>
kraenhansen added a commit that referenced this pull request Aug 10, 2026
* android: patch RN settings.gradle.kts /tmp projectDir for Windows

The Windows unit-test lane failed configuring the React Native build-from-
source composite build:

    Configuring project ':packages:react-native' without an existing directory
    is not allowed. The configured projectDirectory '...\react-native\tmp'
    does not exist

React Native's own settings.gradle.kts declares the intermediate container
projects :packages and :packages:react-native with projectDir = file("/tmp"),
purely to satisfy Gradle 9's rule that every project in a path have an existing
folder. "/tmp" exists on the posix CI hosts but on Windows it is not an
absolute path, so Gradle resolves it to a non-existent <react-native>\tmp and
the build fails before any task runs. This is why only windows-latest was red
while ubuntu and macOS passed.

Add a pnpm patch replacing file("/tmp") with
file(System.getProperty("java.io.tmpdir", "/tmp")): the JVM temp dir is "/tmp"
on posix and %TEMP% on Windows, both of which always exist. Remove the patch
once React Native stops hardcoding "/tmp" upstream.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TVfanKvtyfSsoMgZv3DJtY

* android: point RN /tmp patch at the merged upstream fix

The upstream fix landed on react-native main as 908872a6 (2026-07-28,
react/react-native#57706), after the 0.87 branch cut — so 0.87-stable
does not carry it. Record that in the patch comment so the removal gate is
a concrete react-native version rather than "once upstream fixes it".

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>
kraenhansen added a commit that referenced this pull request Aug 11, 2026
* Phase 1: vendor static_h Hermes, bump to RN 0.87 nightly

Begin migrating off the kraenhansen/hermes fork + JSI-patching path toward
Hermes' first-party Node-API (the static_h branch).

- vendor-hermes: shallow-fetch facebook/hermes at pinned static_h SHA
  0ae42446d1ae669508368b0a18e60c789f76735d; drop the JSI-header copy step
- patch-hermes.rb: rely on REACT_NATIVE_OVERRIDE_HERMES_DIR alone to trigger
  build-from-source; drop the no-op BUILD_FROM_SOURCE var and the obsolete
  RCT_USE_PREBUILT_RNCORE / JSI-patch guard
- CxxNodeApiHostModule: stub env=nullptr (real env arrives in Phase 2 via
  hermes_napi_create_env)
- bump react-native to 0.87.0-nightly-20260529-88857d22f (+ test-app deps,
  react-native-test-app 5.x); regenerate lockfile
- RN 0.87 fallout: add @types/babel__core, fix test-app tsconfig extends for
  the tightened @react-native/typescript-config exports map, delete the
  podspec test asserting the removed guard

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Resolve Xcode app project resiliently in workspaces

react-native-test-app 5.x generates the app's ReactTestApp.xcodeproj under
the nearest node_modules, which in a workspace is the app-local
node_modules (apps/test-app/node_modules/.generated), not the hoisted root.
The workspace can also accumulate stale references to a project under a
different node_modules.

findXcodeProject took the first fileRef unconditionally, which could be the
stale (non-existent) reference or the Pods project. Resolve every app
project reference and pick the first whose project.pbxproj exists on disk,
ignoring Pods.xcodeproj.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Fix test-app tooling for RN 0.87 / Metro 0.84

- Bump @rnx-kit/metro-config to ^2.2.4: 2.1.1 called metro-config's
  exclusionList as a bare function, but Metro 0.84 changed that module to a
  { default } export, breaking `react-native start`.
- Gradle wrapper bumped to 9.3.1 by react-native-test-app 5.x's
  configureGradleWrapper during pod install (RN 0.87 alignment).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Phase 2: create a real Node-API env via hermes_napi_create_env

Replace the `env = nullptr` stub in CxxNodeApiHostModule with a real
Node-API environment: cast the JSI runtime to `IHermes`, read the
underlying `vm::Runtime*` via `getVMRuntimeUnsafe()`, and create the env
with `hermes_napi_create_env(vm, nullptr)`. The env is owned by the
runtime and cached on the module (shared across all addons).

This flips the Phase 1 baseline abort (`assert(status == napi_ok)` right
after `napi_create_object(env=nullptr, …)`) green: with
`MOCHA_REMOTE_CONTEXT=allTests` the iOS-sim suite now reports 14 passing
(node-addon-examples getting-started incl. the Rust ferric addon,
buffers, async, and a js-native-api node-test).

Linking note: the RN `hermesvm` framework force-loads `hermesNapi`, and
the public `hermes_napi_*` entry points are exported from it as long as
Hermes is built from a checkout that includes facebook/hermes #2044
("Export public hermes_napi entry points with NAPI macros") — which the
pinned SHA (0ae42446) already contains. No pod-side linker surgery or
source patching is required; just ensure the vendored checkout is
actually at the pinned SHA (a stale pre-#2044 checkout is what stripped
the symbol during bring-up).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Phase 2: bump Node-API to v10, drop engine/runtime split

All Node-API symbols are now sourced from Hermes' hermesNapi, so the old
engine (js_native_api → libhermes.so) / runtime (node_api →
libnode-api-host.so) distinction and the hand-maintained
IMPLEMENTED_RUNTIME_FUNCTIONS allow-list are obsolete.

- weak-node-api: getNodeApiFunctions defaults to v10 and no longer computes
  the dead `kind`/`libraryPath` fields; CMake compiles the generated
  weak_node_api.cpp at NAPI_VERSION=10 (145 → 155 symbols, adding the v9/v10
  node_api_* surface).
- generate-injector.mts: bind every symbol (no filter) and emit
  `#include <Versions.hpp>` first so the injector TU also compiles at v10.
- Versions.hpp: guarded bump to NAPI_VERSION 10.

Regenerated (gitignored) WeakNodeApiInjector.cpp + weak-node-api/generated
now expose all 155 symbols incl. TSFN and napi_make_callback. Verified:
build, prettier, lint, workspace unit tests, and the weak-node-api native
build + ctest all pass. iOS e2e pending (rides the cold re-vendor).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* vendor-hermes: export public hermes_napi_* entry points

The clean Hermes build at the pinned SHA does NOT export
hermes_napi_create_env (and the other hermes_napi_* entry points). They are
declared in API/napi/hermes_napi.h with NAPI_EXTERN (visibility "default")
but — unlike the sibling js_native_api.h / node_api.h headers — without any
extern "C" wrapping, so they get C++ linkage. The mangled C++ symbols stay
out of the framework's dynamic export table under Hermes' global
-fvisibility=hidden, and a from-scratch build fails at the app link with
"Undefined symbol: hermes_napi_create_env".

vendor-hermes now wraps the hermes_napi.h declarations in
EXTERN_C_START / EXTERN_C_END (both available via the node_api.h include),
giving the entry points C linkage so they export under their unmangled C
names. This mirrors the upstream fix in facebook/hermes#2106. The patch is
idempotent (guarded on EXTERN_C_START) and asserts its anchors exist so a
future Hermes bump fails loudly rather than silently no-op'ing.

Also ignore **/build-tests/** in ESLint (CMake writes compiler_depend.ts
dependency files there that aren't real TypeScript).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* vendor-hermes: apply prettier formatting

Collapse the single-argument `.replace()` call in patchHermesNapiVisibility
onto one line to satisfy prettier:check (fixup for the hermes_napi patch).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Regenerate pnpm-lock.yaml for RN 0.87 dependency bumps

Rebased onto main after the npm->pnpm migration (#381). The original PR's
two package-lock.json maintenance commits (restore public registry URLs,
restore pruned optional platform binaries) are dropped: both addressed
npm-specific lockfile problems that no longer exist under pnpm.

Regenerate pnpm-lock.yaml against the RN 0.87 nightly / react-native-test-app
5.x / @rnx-kit/metro-config bumps so the lockfile matches the workspace
manifests. Verified with pnpm install --frozen-lockfile.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TVfanKvtyfSsoMgZv3DJtY

* vendor-hermes: advance pin to include upstream napi C-linkage fix

Move the pinned Hermes commit forward from 0ae42446 to efcf68e2 on the
static_h branch (a descendant, 18 commits ahead). The only relevant change
in that range is facebook/hermes#2106 "give hermes_napi.h public API C
linkage", which wraps the public hermes_napi_* entry points in extern "C".

That is exactly the fix we were applying locally after cloning: without C
linkage the mangled hermes_napi_create_env symbol stayed out of the
framework export table under Hermes' global -fvisibility=hidden. Now that
the fix is upstream at the pinned commit, drop patchHermesNapiVisibility and
its header-anchor constants entirely — the vendored checkout exports the
entry points as-is.

No commit in the bumped range touches getVMRuntimeUnsafe or the IHermes JSI
interface we depend on, so the unstable-accessor rationale for pinning still
holds.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TVfanKvtyfSsoMgZv3DJtY

* host: match hermes_napi_create_env C linkage after upstream #2106

The pinned Hermes commit now includes facebook/hermes#2106, which wraps the
public hermes_napi_* entry points in extern "C". Hermes therefore exports the
unmangled C symbol for hermes_napi_create_env.

CxxNodeApiHostModule forward-declares that entry point (to avoid including
Hermes' node_api.h) but did so with C++ linkage, so it referenced the mangled
name. After the pin bump the two no longer matched and the iOS app failed to
link with "Undefined symbol: hermes_napi_create_env".

Wrap the forward declaration in extern "C" so the reference resolves to the
exported unmangled symbol.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TVfanKvtyfSsoMgZv3DJtY

* android: inject ExecOperations for Gradle 9 compatibility (#386)

RN 0.87 bumps the Gradle wrapper to 9.x, which removed Project.exec(). The
linkNodeApiModules task used the bare `exec {}` closure in its doLast action,
failing every Android build (and gradle.test.ts on all platforms) with
"Could not find method exec()". Inject the ExecOperations service via an
@Inject-annotated interface and call injectedExecOps.execOps.exec {} instead.

Greens the ubuntu and macOS unit-test lanes. Windows surfaces a separate,
pre-existing RN 0.87 / Gradle 9 issue (missing react-native/tmp projectDir)
tracked separately.

* android: patch RN settings.gradle.kts /tmp projectDir for Windows (#387)

* android: patch RN settings.gradle.kts /tmp projectDir for Windows

The Windows unit-test lane failed configuring the React Native build-from-
source composite build:

    Configuring project ':packages:react-native' without an existing directory
    is not allowed. The configured projectDirectory '...\react-native\tmp'
    does not exist

React Native's own settings.gradle.kts declares the intermediate container
projects :packages and :packages:react-native with projectDir = file("/tmp"),
purely to satisfy Gradle 9's rule that every project in a path have an existing
folder. "/tmp" exists on the posix CI hosts but on Windows it is not an
absolute path, so Gradle resolves it to a non-existent <react-native>\tmp and
the build fails before any task runs. This is why only windows-latest was red
while ubuntu and macOS passed.

Add a pnpm patch replacing file("/tmp") with
file(System.getProperty("java.io.tmpdir", "/tmp")): the JVM temp dir is "/tmp"
on posix and %TEMP% on Windows, both of which always exist. Remove the patch
once React Native stops hardcoding "/tmp" upstream.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TVfanKvtyfSsoMgZv3DJtY

* android: point RN /tmp patch at the merged upstream fix

The upstream fix landed on react-native main as 908872a6 (2026-07-28,
react/react-native#57706), after the 0.87 branch cut — so 0.87-stable
does not carry it. Record that in the patch comment so the removal gate is
a concrete react-native version rather than "once upstream fixes it".

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>

* host: apply the Kotlin plugin only when built-in Kotlin is unavailable

AGP 9 ships built-in Kotlin support and enables it by default, which
registers the `kotlin` extension itself. Applying `kotlin-android` on top
of that fails the consumer's build with "Cannot add extension with name
'kotlin'", so any consumer who has migrated off the `builtInKotlin=false`
opt-out currently cannot build against this package.

Gate the plugin on the AGP major version and the consumer's opt-out, so
the library works both for consumers still on AGP 8 (or opted out while
they migrate) and for those already on built-in Kotlin. React Native's
own ReactAndroid no longer applies the Kotlin plugin either, as of 0.87.

Reuses the `com.android.Version` idiom already used by supportsNamespace().

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* deps: bump react-native to 0.87.0-rc.4

Moves off the 0.87.0-nightly-20260529 pin onto the 0.87 release
candidate. The motivating change is AGP: the nightly still resolved AGP
8.12, while AGP 9.2.1 landed on the 0.87 line in mid-June. AGP 9 is what
react-native-test-app assumes for React Native >= 0.87 (it forces Gradle
9.4.1 and then uses the built-in Kotlin `kotlin {}` extension), so the
test app could not configure against the old pin.

The Windows `/tmp` projectDir patch is unchanged — settings.gradle.kts is
byte-identical between the two versions (same blob 2036e0f), so only the
file name and the patchedDependencies key move. The fix for it is still
main-only, so the patch stays until we are on 0.88+.

Also switches the two React Native facing tsconfigs to nodenext module
resolution. 0.87.0-rc.4 drops react-native's top-level `types` field and
flips the default `types` export condition to the generated strict API,
neither of which the node10 resolution inherited from
@tsconfig/react-native can see — the package stopped resolving entirely
(TS2688). @tsconfig/react-native is stale at every published version
through 3.0.9, so there is nothing to bump there. Emit is unaffected:
both projects still produce CommonJS. The strict API exports TurboModule
and TurboModuleRegistry, and still references react-native's globals, so
console/require stay typed.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* test-app: adopt built-in Kotlin on Android, opt out of the AGP 9 DSL

With React Native 0.87 the test app builds against AGP 9.2.1, where
built-in Kotlin is enabled by default. Nothing in the build needs the
Kotlin plugin any more: ReactAndroid dropped it upstream,
react-native-test-app's modules are gated on it, and react-native-node-api
now only applies it when built-in Kotlin is unavailable. So unlike the
React Native app template, we do not set `android.builtInKotlin=false`.

The new DSL is a different matter and stays opted out: both of
react-native-test-app's Gradle modules still use the old one, and that is
third-party code. AGP 10 removes this opt out, so it is tracked in #389
along with the upstream code that has to migrate first.

Also pins the Gradle wrapper at 9.4.1, which react-native-test-app rewrites
it to at run time for React Native >= 0.87 — pinning it ourselves keeps CI
from building with a dirty working tree.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* deps: bump react-native to a 0.88 nightly and drop the Windows patch

React Native 57706 ("Fix build-from-source on Windows: use JVM temp dir
instead of hardcoded /tmp", 908872a6, 2026-07-28) landed on main after
the 0.87 branch cut, so it ships on the 0.88 line and not in 0.87.0-rc.4.
Verified in the published artifact, not just the tree: the tarball for
0.88.0-nightly-20260809-db662caea carries the fix in settings.gradle.kts,
the exact file (and path) we were patching. Our patch is now redundant.

Dropping it is what makes Android build. Patching a dependency makes pnpm
encode the patch hash into the virtual store directory as
`..._patch_hash=<hash>`, and prefab — which the Android Gradle plugin runs
over react-native's package directory — parses a positional path
containing `=` as an option name and dies with "Error: no such option".
That is google/prefab#187, open since March and
hitting every pnpm user with a patched dependency. With no patched
dependencies there is no `=` in the store, so the bug goes untriggered.

Requires react-native-test-app >= 5.4.8, which widened its peer range to
`0.76 - 0.87 || >=0.88.0-0 <0.88.0` — a prerelease window covering exactly
these nightlies. 5.4.5 did not accept 0.88 at all, so the floor moves up.

Everything the AGP 9 work depends on is unchanged on this line: AGP 9.2.1,
Kotlin 2.2.0, and react-native-test-app still resolves Gradle 9.4.1 for
0.88, matching the pinned wrapper.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* host: link the renamed hermesvm prefab module on Android

React Native renamed the prefab module published by `hermes-engine` from
`libhermes` to `hermesvm` between 0.81 and 0.83 — the Android counterpart
of the `hermesvm` framework this branch already links against on Apple
platforms. This CMakeLists has been on `libhermes` since #308, which was
correct while the repo targeted 0.81, and stayed behind when this branch
jumped to 0.87/0.88.

Without it CMake fails to configure:

    Target "node-api-host" links to target "hermes-engine::libhermes" but
    the target was not found.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* test-app: opt out of built-in Kotlin after all

fa4424b deliberately left `android.builtInKotlin` unset, on the reasoning
that nothing in the build still needs the Kotlin plugin. That reasoning
was wrong, and only a real Android build showed it:

    ComponentActivity.kt:33:9 Unresolved reference 'ComponentActivityDelegate'

react-native-test-app's app module pulls in version-specific sources with
`main.java.srcDirs += [...]` — src/reactactivitydelegate-0.75/java,
src/reactapplication-0.76/java, src/camera/java and others. The Kotlin
plugin compiles the Kotlin in those directories; AGP's built-in Kotlin
only picks up the standard source directories, so every symbol defined in
an added one goes unresolved (`testApp`, `reactHost`, `canUseCamera`,
`ComponentBottomSheetDialogFragment`, …). Their `useBuiltInKotlin` gate
avoids the plugin-conflict failure but does not make the module itself
built-in-Kotlin ready, which is why their template ships this opt out.

react-native-node-api itself stays built-in-Kotlin ready via the
conditional in ee41927 — with this flag set it applies the Kotlin plugin,
and for a consumer on built-in Kotlin it steps aside. This is only about
the test harness.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* test-app: fail the Android run as soon as the app crashes

`mocha-remote` waits indefinitely for a client to connect and has no
notion of the app dying. When the test app crashed on startup, nothing
ever connected: the run sat idle until the 75 minute step timeout, with
the actual cause — a `FATAL EXCEPTION` one second after `am start` —
only visible by downloading the logcat artifact afterwards.

Add a watchdog that follows `adb logcat -b crash` alongside the app and
exits non-zero when the crash buffer names the test app, printing the
stack trace inline. `concurrently --kill-others-on-fail` then tears down
Metro and the app run, and `mocha-remote` inherits the failing exit code,
so a startup crash fails the job in seconds rather than in an hour.

It deliberately only reacts to crashes — an app that hangs or never
launches still falls back to the job timeout.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* test-app: don't let the crash watchdog hold the step's stderr open

The watchdog correctly failed the run on the first crash it saw, but the
job kept hanging afterwards: `@actions/exec` — how the emulator-runner
action runs each line of the step's script — resolves a command only once
the stdio streams it handed out are closed, and the `adb logcat` child
inherited our stderr. Exiting orphaned it, so that pipe stayed open and
the step waited on a dangling file descriptor long after everything else
had been torn down.

Give the child no stderr of its own and kill it on the way out. Verified
by spawning the watchdog the way `@actions/exec` does: before, the
process exited after 1.6s but its stdio never closed; now both happen
together.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* vendor-hermes: advance the pin past Hermes' JSI_UNSTABLE default flip

The Android test app crashed on startup, in `NodeApiHostPackage.<init>`:

    java.lang.UnsatisfiedLinkError: dlopen failed: cannot locate symbol
    "_ZTIN8facebook3jsi10SerializedE" referenced by ".../libhermesvm.so"
    com.facebook.soloader.SoLoaderDSONotFoundError: couldn't find DSO to
    load: libhermesvm.so

That symbol is `typeinfo for facebook::jsi::Serialized`. JSI's
`Serialized` / `ISerialization` APIs sit behind `#ifdef JSI_UNSTABLE`,
and React Native never defines it when building the `libjsi.so` it ships
in the ReactAndroid AAR. Our pinned Hermes still defaulted `JSI_UNSTABLE`
to ON, so `hermesvm` compiled those APIs in and referenced symbols that
nothing in the APK defines.

Apple builds are unaffected because JSI is compiled into the `hermesvm`
framework itself; on Android the two are separate shared libraries, and
RN's hermes-engine build imports `libjsi.so` rather than packaging the
copy Hermes builds for itself.

facebook/hermes 5a795c9f8 ("Fix: JSI_UNSTABLE CMake flag should be OFF by
default") is the immediate child of the previous pin, so this picks up
the one-line fix and nothing else.

Verified by rebuilding the release APK for x86_64: `libhermesvm.so` no
longer references `jsi::Serialized`, and every undefined JSI symbol it
does have is defined by a library shipped in the APK.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* host: create one Node-API env per addon

Node creates a fresh napi_env for every addon it loads (see the "Create a
new napi_env for this specific module" branch of
napi_module_register_by_symbol in src/node_api.cc), because the env holds
addon-scoped state: instance data, last error info and the addon's
Node-API version. Sharing one env across all addons breaks that isolation
most visibly for instance data, where the single slot on napi_env__ means
two addons built on Napi::Addon<T> clobber each other — the second
registration finalizes the first addon's object, and Addon::Unwrap then
casts the wrong type.

Move the env onto the addon record and create it during initialization.
hermes_napi_create_env() allocates a fresh env per call and registers its
teardown with the vm::Runtime, so ownership is unchanged: each env is
torn down with the runtime.

The call invoker registry is already keyed by env, so it needs no change
beyond dropping entries when an env goes away — with an env per addon
those would otherwise accumulate across reloads.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* Add changeset for the static_h Node-API adoption

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* docs: describe the vendored Hermes instead of a patched one

Node-API is implemented in Hermes itself now, so nothing is patched or
forked: we build from a pinned commit on the static_h branch. Also
corrects HOW-IT-WORKS, which described the removed
jsi::Runtime::createNodeApiEnv.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* docs: describe the Node-API host struct in HOW-IT-WORKS

Hermes implements both js_native_api.h and node_api.h; what it can't
supply without libuv are the scheduling primitives, which the host passes
in as a hermes_napi_host struct.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants